lkml.org 
[lkml]   [2010]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [linux-karma-devel] [PATCH] omfs: fix memory leak
On Mon, Jul 05, 2010 at 01:12:39AM -0400, Davidlohr Bueso wrote:
> Isn't put_super() called to free data when things run "normally", like
> for unmounting? So this function does two things:

Ok, I checked it out and you are right, FS put_super is only called
after successful mount so there is a leak. I'll take your patch,
but please:

- remove the /* success */ comment, IMO it's just noise
- write the if conditional as the more usual:
if (ret)
> kfree(sbi->s_imap)
> kfree(sbi)
>
> However, in omfs_get_imap() 'sbi->s_imap' is freed upon failure, so
> wouldn't this also crash on the first kfree in omfs_put_super()?

This is ok, since sbi->s_imap is set to null in that case and
kfree(NULL) is fine.

Thanks for the review!

--
Bob Copeland %% www.bobcopeland.com



\
 
 \ /
  Last update: 2010-07-05 16:05    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean