lkml.org 
[lkml]   [2010]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: Fwd: Possible bug in net/ipv4/route.c?
    From
    Date
    Le lundi 05 juillet 2010 à 21:22 +0800, Herbert Xu a écrit :
    > On Mon, Jul 05, 2010 at 02:59:14PM +0200, Eric Dumazet wrote:
    > >
    > > Why do we clear full 48 bytes skb->cb[] in skb_alloc(), if no protocol
    > > stack should rely it being zero ?
    >
    > Unless a protocol is allocating the skb itself, then the fact
    > that skb_alloc clears skb->cb is no guarantee that the skb->cb
    > will be zero.

    I see. We could :

    Avoid this memset(skb->cb, 0, sizeof(skb->cb)) in fastpath.

    or in debug mode, poison it to trigger errors more often.

    Thanks


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-07-05 15:37    [W:0.019 / U:31.684 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site