lkml.org 
[lkml]   [2010]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Fwd: Possible bug in net/ipv4/route.c?
From
Date
Le lundi 05 juillet 2010 à 20:06 +0800, Herbert Xu a écrit :
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
> >
> >> 2) The layer using skb->cb[] should clear this area after use and
> >> before handing the skb to another layer. Ubicom should modify the
> >> driver to clear the skb->cb[] area before sending it up the line.
> >>
> >
> > This is the right option. If you use one word in cb[], only your driver
> > knows how to clear it efficiently.
>
> Absolutely not! No protocol stack should rely on an external skb
> having a zero cb.
>

Why do we clear full 48 bytes skb->cb[] in skb_alloc(), if no protocol
stack should rely it being zero ?



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-07-05 15:33    [from the cache]
©2003-2011 Jasper Spaans