lkml.org 
[lkml]   [2010]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv10 2.6.35-rc6-tip 11/14] perf: perf interface for uprobes
Em Sat, Jul 31, 2010 at 08:27:48AM +0530, Srikar Dronamraju escreveu:
> > > @@ -1598,15 +1812,19 @@ struct __event_package {
> > > int add_perf_probe_events(struct perf_probe_event *pevs, int npevs,
> > > bool force_add, int max_tevs)
> > > {
> > > - int i, j, ret;
> > > + int i, j, ret = 0;
> > > struct __event_package *pkgs;
> > >
> > > pkgs = zalloc(sizeof(struct __event_package) * npevs);
> > > if (pkgs == NULL)
> > > return -ENOMEM;
> > >
> > > - /* Init vmlinux path */
> > > - ret = init_vmlinux();
> > > + if (!pevs->upid)
> > > + /* Init vmlinux path */
> > > + ret = init_vmlinux();
> > > + else
> > > + ret = init_perf_uprobes();
> > > +
> > > if (ret < 0)
> >
> > pkgs leaks here.
>
> Right, but I dont think this leak was introduced by my patch(s). I
> guess its better fixed by a different patch.

Sorry, will fix that then on a separate patch.

- Arnaldo


\
 
 \ /
  Last update: 2010-07-31 21:33    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog