lkml.org 
[lkml]   [2010]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]irq:manage.c Fix warning: variable 'old_name' set but not used
haven't heard anything on this.. is this in the vicinity of being a 
right solution?

> Not sure if this is the right approach with this.. The below
> fixes a warning message generated by GCC
> CC kernel/irq/manage.o
> kernel/irq/manage.c: In function '__setup_irq':
> kernel/irq/manage.c:652:14: warning: variable 'old_name' set but not used
>
> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>
> ---
> kernel/irq/manage.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index e149748..99d2f39 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -733,6 +733,9 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
> if (!((old->flags& new->flags)& IRQF_SHARED) ||
> ((old->flags ^ new->flags)& IRQF_TRIGGER_MASK)) {
> old_name = old->name;
> + if(old_name) {
> + printk(KERN_ERR "IRQ mismatch: %d %s\n", IRQF_SHARED, old_name);
> + }
> goto mismatch;
> }
>



\
 
 \ /
  Last update: 2010-07-31 21:07    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog