lkml.org 
[lkml]   [2010]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]acpi:glue.c Fix warning: variable 'ret' set but not used
whats going on with this patch? havent heard anything on this.

> Fix a warning message generated by gcc:
> CC drivers/acpi/glue.o
> drivers/acpi/glue.c: In function 'acpi_bind_one':
> drivers/acpi/glue.c:163:7: warning: variable 'ret' set but not used
>
> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
> Signed-off-by: David Howells<dhowells@redhat.com>
>
> ---
> drivers/acpi/glue.c | 14 +++++++++++---
> 1 files changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c
> index 4af6301..23b16e6 100644
> --- a/drivers/acpi/glue.c
> +++ b/drivers/acpi/glue.c
> @@ -145,6 +145,7 @@ static int acpi_bind_one(struct device *dev, acpi_handle handle)
> {
> struct acpi_device *acpi_dev;
> acpi_status status;
> + int fn, pn;
>
> if (dev->archdata.acpi_handle) {
> dev_warn(dev, "Drivers changed 'acpi_handle'\n");
> @@ -160,12 +161,19 @@ static int acpi_bind_one(struct device *dev, acpi_handle handle)
>
> status = acpi_bus_get_device(handle,&acpi_dev);
> if (!ACPI_FAILURE(status)) {
> - int ret;
>
> - ret = sysfs_create_link(&dev->kobj,&acpi_dev->dev.kobj,
> + fn = sysfs_create_link(&dev->kobj,&acpi_dev->dev.kobj,
> "firmware_node");
> - ret = sysfs_create_link(&acpi_dev->dev.kobj,&dev->kobj,
> + pn = sysfs_create_link(&acpi_dev->dev.kobj,&dev->kobj,
> "physical_node");
> + if (fn || pn) {
> + dev_warn(&acpi_dev->dev,
> + "Failed to create link(s) to %s %s:"
> + " %d\n",
> + dev_driver_string(dev), dev_name(dev),
> + fn ?: pn);
> + return AE_ERROR;
> + }
> if (acpi_dev->wakeup.flags.valid) {
> device_set_wakeup_capable(dev, true);
> device_set_wakeup_enable(dev,



\
 
 \ /
  Last update: 2010-07-31 20:53    [W:0.045 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site