lkml.org 
[lkml]   [2010]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] drivers: Fixes a typo from "dev" to "ndev" that caused compilation erros.
From
From: Henrique Camargo <henrique.camargo@ensitec.com.br>
Date: Thu, 29 Jul 2010 12:51:49 -0300

> From: Henrique Camargo

From lines need valid email addresses. But in this case since you
are the person who wrote the patch, adding another From: tag in
the message body is superfluous and you can just omit it.

> diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
> index 25e14d2..b89b7bf 100644
> --- a/drivers/net/davinci_emac.c
> +++ b/drivers/net/davinci_emac.c
> @@ -1182,8 +1182,8 @@ static int emac_net_tx_complete(struct emac_priv *priv,
> struct net_device *ndev = priv->ndev;
> u32 cnt;
>
> - if (unlikely(num_tokens && netif_queue_stopped(dev)))
> - netif_start_queue(dev);
> + if (unlikely(num_tokens && netif_queue_stopped(ndev)))
> + netif_start_queue(ndev);

Your patch is corrupted, tab characters have been turned into spaces by
your email client.

This makes your patch unusable.

Please fix up these errors and resubmit your patch.

Thank you.


\
 
 \ /
  Last update: 2010-07-31 07:23    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog