lkml.org 
[lkml]   [2010]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] random: reorder struct entropy_store to remove padding on 64bits
On Wed, Jul 28, 2010 at 11:02:28AM -0500, Matt Mackall wrote:
> On Wed, 2010-07-28 at 10:32 +0100, Richard Kennedy wrote:
> > Re-order structure entropy_store to remove 8 bytes of padding on
> > 64 bit builds, so shrinking this structure from 72 to 64 bytes
> > and allowing it to fit into one cache line.
>
> I have a vague memory that we reordered things so that the r/w bits
> would be on a separate cache line than the r/o bits. But as we never
> added the alignment primitives to actually enforce that, I guess it
> doesn't matter much.
>
> > Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
>
> Signed-off-by: Matt Mackall <mpm@selenic.com>

Patch applied. Thanks!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


\
 
 \ /
  Last update: 2010-07-31 14:01    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog