lkml.org 
[lkml]   [2010]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[008/140] r8169: fix mdio_read and update mdio_write according to hw specs
    2.6.33-stable review patch.  If anyone has any objections, please let us know.

    ------------------


    From: Timo Teräs <timo.teras@iki.fi>

    [ Upstream commit 81a95f049962ec20a9aed888e676208b206f0f2e ]

    Realtek confirmed that a 20us delay is needed after mdio_read and
    mdio_write operations. Reduce the delay in mdio_write, and add it
    to mdio_read too. Also add a comment that the 20us is from hw specs.

    Signed-off-by: Timo Teräs <timo.teras@iki.fi>
    Acked-by: Francois Romieu <romieu@fr.zoreil.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/net/r8169.c | 12 +++++++++---
    1 file changed, 9 insertions(+), 3 deletions(-)

    --- a/drivers/net/r8169.c
    +++ b/drivers/net/r8169.c
    @@ -558,10 +558,10 @@ static void mdio_write(void __iomem *ioa
    udelay(25);
    }
    /*
    - * Some configurations require a small delay even after the write
    - * completed indication or the next write might fail.
    + * According to hardware specs a 20us delay is required after write
    + * complete indication, but before sending next command.
    */
    - udelay(25);
    + udelay(20);
    }

    static int mdio_read(void __iomem *ioaddr, int reg_addr)
    @@ -581,6 +581,12 @@ static int mdio_read(void __iomem *ioadd
    }
    udelay(25);
    }
    + /*
    + * According to hardware specs a 20us delay is required after read
    + * complete indication, but before sending next command.
    + */
    + udelay(20);
    +
    return value;
    }


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-07-30 20:53    [W:0.023 / U:31.020 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site