[lkml]   [2010]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] act_nat: the checksum of ICMP doesn't have pseudo header
On Fri, Jul 30, 2010 at 08:04:18AM +0800, Changli Gao wrote:
> after updating the value of the ICMP payload, inet_proto_csum_replace4() should
> be called with zero pseudohdr.
> Signed-off-by: Changli Gao <>

No, the code is correct as is. We need to update the checksum
even if the checksum is partial, which is what the 1 is for.

Email: Herbert Xu <>
Home Page:
PGP Key:

 \ /
  Last update: 2010-07-30 11:11    [W:0.041 / U:4.684 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site