lkml.org 
[lkml]   [2010]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[024/205] cifs: dont attempt busy-file rename unless its in same directory
    2.6.34-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Jeff Layton <jlayton@redhat.com>

    commit ed0e3ace576d297a5c7015401db1060bbf677b94 upstream.

    Busy-file renames don't actually work across directories, so we need
    to limit this code to renames within the same dir.

    This fixes the bug detailed here:

    https://bugzilla.redhat.com/show_bug.cgi?id=591938

    Signed-off-by: Jeff Layton <jlayton@redhat.com>
    Signed-off-by: Steve French <sfrench@us.ibm.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    fs/cifs/inode.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/fs/cifs/inode.c
    +++ b/fs/cifs/inode.c
    @@ -1389,6 +1389,10 @@ cifs_do_rename(int xid, struct dentry *f
    if (rc == 0 || rc != -ETXTBSY)
    return rc;

    + /* open-file renames don't work across directories */
    + if (to_dentry->d_parent != from_dentry->d_parent)
    + return rc;
    +
    /* open the file to be renamed -- we need DELETE perms */
    rc = CIFSSMBOpen(xid, pTcon, fromPath, FILE_OPEN, DELETE,
    CREATE_NOT_DIR, &srcfid, &oplock, NULL,



    \
     
     \ /
      Last update: 2010-07-30 20:35    [W:0.020 / U:0.916 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site