[lkml]   [2010]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: Memory corruption during hibernation since 2.6.31
* Hugh Dickins <> [2010-07-29 21:32:35]:

> On Thu, Jul 29, 2010 at 9:18 PM, Balbir Singh <> wrote:
> >
> > Couldn't we reuse PF_* flags to differentiate between the paths, if
> > that is what it eventually boils down to? On an unrelated note, I was
> > looking at shrink_all_memory() and wondering if swappiness really
> > mattered there.
> So far as the swap-reuse issue goes, I don't see that a PF_ flag
> would help: the threads that already worry about such issues do
> the set_freezable()/try_to_freeze() thing, and won't get into
> trouble anyway; we don't want to force every other thread to
> have to do something special now, better just check global state
> in the very few places its needed.

We already do that with PF_MEMALLOC in several places. If the goal is
to avoid resuing the swap entry at all times after hibernate, the
solution needs to be a global state solution like you suggest.

> On the unrelated note: better in an unrelated thread!

Sure :)

Three Cheers,

 \ /
  Last update: 2010-07-30 08:39    [W:0.067 / U:5.204 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site