Messages in this thread | | | Date | Fri, 30 Jul 2010 06:59:30 -0500 | From | Jason Wessel <> | Subject | Re: [PATCH] [8/23] KGDB: Remove set but unused newPC |
| |
On 06/10/2010 06:10 AM, Andi Kleen wrote: > I'm not fully sure this is the correct fix, maybe this > was a bug and newPC should really have a side effect. > Jason? > > Andi,
This looks fine to me. The newPC got there from the merge of the 32/64 kgdb specific implementation. Definitely don't need it anymore.
I'll queue it for 2.6.36.
Thanks, Jason.
> Found by gcc 4.6's new warnings > > Cc: jason.wessel@windriver.com > > Signed-off-by: Andi Kleen <ak@linux.intel.com> > > --- > arch/x86/kernel/kgdb.c | 3 --- > 1 file changed, 3 deletions(-) > > Index: linux-2.6.35-rc2-gcc/arch/x86/kernel/kgdb.c > =================================================================== > --- linux-2.6.35-rc2-gcc.orig/arch/x86/kernel/kgdb.c > +++ linux-2.6.35-rc2-gcc/arch/x86/kernel/kgdb.c > @@ -458,7 +458,6 @@ int kgdb_arch_handle_exception(int e_vec > { > unsigned long addr; > char *ptr; > - int newPC; > > switch (remcomInBuffer[0]) { > case 'c': > @@ -469,8 +468,6 @@ int kgdb_arch_handle_exception(int e_vec > linux_regs->ip = addr; > case 'D': > case 'k': > - newPC = linux_regs->ip; > - > /* clear the trace bit */ > linux_regs->flags &= ~X86_EFLAGS_TF; > atomic_set(&kgdb_cpu_doing_single_step, -1); >
| |