lkml.org 
[lkml]   [2010]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/4] posix-cpu-timers: Introduction of wall clocks
    On Fri, 30 Jul 2010 11:57:45 +0200
    Tomasz Buchert <tomasz.buchert@inria.fr> wrote:

    > - read_lock(&tasklist_lock);
    > + rcu_read_lock();
    > p = find_task_by_vpid(pid);
    > if (!p || !(POSIX_CLOCK_PERTHREAD(which_clock) ?
    > same_thread_group(p, current) : thread_group_leader(p))) {
    > error = -EINVAL;
    > }
    > - read_unlock(&tasklist_lock);
    > + rcu_read_unlock();

    IIRC thread_group_leader(p) is wrong here, has_group_leader_pid(p)
    should be used. Beside this change alone should be a separate patch,
    not part of a "new feature" patch.

    Stanislaw


    \
     
     \ /
      Last update: 2010-07-30 13:33    [W:0.019 / U:0.980 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site