Messages in this thread | | | Date | Sat, 3 Jul 2010 21:22:38 -0600 | From | Matthew Wilcox <> | Subject | Re: [PATCH] Break out types from <linux/list.h> to <linux/list_types.h>. |
| |
On Sat, Jul 03, 2010 at 09:47:58PM -0400, Chris Metcalf wrote: > Sounds like we have a consensus on moving the list_head, hlist_head, and > hlist_node types to <linux/types.h>. I assume everyone is agreed that > initializers, etc., should stay in <linux/list.h>. I will send out a > revised git patch on Sunday.
Yes, I think that's reasonable. By way of comparison, ATOMIC_INIT, etc. stayed in atomic.h. It makes sense -- you only need the types for structure definitions, you don't need the initialisers.
I suppose if you have a header which defines an initialiser like sched.h does, you'll want the list.h initialisers, but anything that complex should be able to handle including the full list.h header.
-- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."
| |