Messages in this thread | | | Subject | Re: [PATCH] lib/scatterlist: Hook sg_kmalloc into kmemleak (v2) | From | Catalin Marinas <> | Date | Wed, 28 Jul 2010 22:32:42 +0100 |
| |
On Tue, 2010-07-27 at 09:44 +0100, Chris Wilson wrote: > kmemleak ignores page_alloc() and so believes the final sub-page > allocation using the plain kmalloc is decoupled and lost. This leads to > lots of false-positives with code that uses scatterlists. > > The options seem to be either to tell kmemleak that the kmalloc is not > leaked or to notify kmemleak of the page allocations. The danger of the > first approach is that we may hide a real leak, so choose the latter > approach (of which I am not sure of the downsides). > > v2: Added comments on the suggestion of Catalin. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Thanks. The patch looks good. I'll place it in my kmemleak branch and send it to Linus together with other kmemleak patches (hopefully I won't miss the merging window as I'm going on holiday for a week).
-- Catalin
| |