lkml.org 
[lkml]   [2010]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 5/5] staging:ti dspbridge: replace simple_strtoul by strict_strtoul
    From
    On Wed, Jul 28, 2010 at 5:40 PM, Ernesto Ramos <ernesto@ti.com> wrote:
    > Replace simple_strtoul by strict_strtoul in atoi function.
    In general the question what is the purpose here to do the change?

    > @@ -1023,7 +1025,9 @@ static s32 atoi(char *psz_buf)
    >                base = 16;
    >        }
    >
    > -       return simple_strtoul(pch, NULL, base);
    > +       ret_val = strict_strtoul(pch, base, &res);
    > +
    > +       return ret_val ? : res;
    May be better to use explicit values in condition?

    --
    With Best Regards,
    Andy Shevchenko
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-07-28 20:47    [W:2.321 / U:1.652 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site