lkml.org 
[lkml]   [2010]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] Tight check of pfn_valid on sparsemem - v4
    From
    Hi, Kame.

    On Tue, Jul 27, 2010 at 5:13 PM, KAMEZAWA Hiroyuki
    <kamezawa.hiroyu@jp.fujitsu.com>
    >> Perhaps the mem_section array.  Using a symbol that is part of
    >> the model pre-checks can remove a global symbol lookup and has the side
    >> effect of making sure our pfn_valid is for the right model.
    >>
    >
    > But yes, maybe it's good to make use of a fixed-(magic)-value.

    fixed-magic-value?
    Yes. It can be good for some debugging.
    But as Christoph pointed out, we need some strict check(ex,
    PG_reserved) for preventing unlucky valid using of magic value in
    future.
    But in fact I have a concern to use PG_reserved since it can be used
    afterward pfn_valid normally to check hole in non-hole system. So I
    think it's redundant.

    Hmm..

    --
    Kind regards,
    Minchan Kim
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-07-27 12:03    [W:0.021 / U:90.516 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site