lkml.org 
[lkml]   [2010]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH v1 02/15] perf: export generic hardware events via sysfs
On 26.07.10 22:18:23, Lin Ming wrote:

> > > /sys/devices/system/cpu/cpu0/events
> > > |-- L1-dcache-load-misses
> > > | |-- config
> > > | `-- type

vs.

> > |-- L1-dcache-load-misses ===> event name
> > | `-- id ===> event id

> > This is very simple and flexible and solves the original problem too.
>
> Yeah, this is flexible. I'll think about this closely.

The thing is, if you start introducing the config/type i/f, we will
stick with it for a long time. I want to avoid this from the
beginning.

Using an id only would work with your current implementation too, you
only need to maintain an id -> config/type mapping, maybe in some
private data section, without exporting it to userspace.

-Robert

--
Advanced Micro Devices, Inc.
Operating System Research Center



\
 
 \ /
  Last update: 2010-07-27 10:31    [from the cache]
©2003-2011 Jasper Spaans