Messages in this thread | | | Date | Wed, 28 Jul 2010 11:16:03 +0800 | From | Américo Wang <> | Subject | Re: [PATCH v2] checkpatch: Add warnings for use of mdelay() |
| |
On Tue, Jul 27, 2010 at 10:27:10AM -0700, Israel Schlesinger wrote: >mdelay is a busy-wait loop which is wasteful. If at all possible, >callers should use msleep instead of mdelay. > >The only time mdelay is really appropriate is in atomic context, >however, delays of 1ms+ in atomic context are rather expensive, so >a warning for this case is probably appropriate as well to encourage >people to move such expensive delays outside of atomic context >
Then udelay() is also preferred...
| |