[lkml]   [2010]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC PATCH] sysrq: don't hold the sysrq_key_table_lock during the handler
On Mon, 26 Jul 2010 17:54:02 +0800
Xiaotian Feng <> wrote:

> sysrq_key_table_lock is used to protect the sysrq_key_table, make sure
> we get/replace the right operation for the sysrq. But in __handle_sysrq,
> kernel will hold this lock and disable irqs until we finished op_p->handler().
> This may cause false positive watchdog alert when we're doing "show-task-states"
> on a system with many tasks.

It would be better to find a suitable point in an inner loop and add an
appropriately-commented touch_nmi_watchdog().

That way the problem gets fixed for all irqs-off callers, not just one
of them.

 \ /
  Last update: 2010-07-28 01:39    [W:0.113 / U:5.208 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site