Messages in this thread | | | Subject | Re: [PATCH net-next] drivers/net/bfin_mac.c: Use pr_fmt, netdev_<level> | From | Joe Perches <> | Date | Tue, 27 Jul 2010 13:52:37 -0700 |
| |
On Tue, 2010-07-27 at 13:44 -0700, Stephen Hemminger wrote: > On Tue, 27 Jul 2010 12:22:11 -0700 > Joe Perches <joe@perches.com> wrote: > > +static struct sk_buff *bfin_alloc_skb(void) > > +{ > > + /* allocate a new skb */ > > + struct sk_buff *new_skb = dev_alloc_skb(PKT_BUF_SIZE + NET_IP_ALIGN); > > + > > + if (!new_skb) > > + return NULL; > > + > > + skb_reserve(new_skb, NET_IP_ALIGN); > > Why not use netdev_alloc_skb_ip_align ?
I was consolidating duplicated code.
It could be changed, but right now, desc_list_init isn't passed a struct netdevice.
Perhaps you'll submit that as a follow-on?
| |