Messages in this thread | | | Date | Tue, 27 Jul 2010 18:13:31 +0400 | From | Anton Vorontsov <> | Subject | Re: [GIT PULL] battery-2.6.35.git |
| |
On Tue, Jul 27, 2010 at 04:03:14PM +0200, Geert Uytterhoeven wrote: > On Tue, Jul 27, 2010 at 15:51, Anton Vorontsov <cbouatmailru@gmail.com> wrote: > > diff --git a/drivers/power/ds2782_battery.c b/drivers/power/ds2782_battery.c > > index d762a0c..9b3b4b7 100644 > > --- a/drivers/power/ds2782_battery.c > > +++ b/drivers/power/ds2782_battery.c > > @@ -43,10 +43,9 @@ > > struct ds278x_info; > > > > struct ds278x_battery_ops { > > - int (*get_current)(struct ds278x_info *info, int *current_uA); > > - int (*get_voltage)(struct ds278x_info *info, int *voltage_uA); > > - int (*get_capacity)(struct ds278x_info *info, int *capacity_uA); > > - > > + int (*get_battery_current)(struct ds278x_info *info, int *current_uA); > > + int (*get_battery_voltage)(struct ds278x_info *info, int *voltage_uA); > > + int (*get_battery_capacity)(struct ds278x_info *info, int *capacity_uA); > > What's the meaning of these `uA' namings? At first I thought `micro Ampère', but > that can't be correct for voltage (`uV'?) and capacity (`uAh'?).
Yeah, the names aren't quite right. But they were wrong before that patch too, so a patch on top to fix these issues will work.
Cc'ing driver authors.
Thanks Geert!
-- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |