Messages in this thread | | | From | Grant Likely <> | Date | Mon, 26 Jul 2010 16:51:01 -0600 | Subject | Re: [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid() |
| |
On Mon, Jul 26, 2010 at 4:48 PM, David Miller <davem@davemloft.net> wrote: > From: Grant Likely <grant.likely@secretlab.ca> > Date: Mon, 26 Jul 2010 16:42:20 -0600 > >> It protects against some later include file doing a #define >> of_node_to_nid and thus resulting in an inconsistent definition. If >> some code tries to do this then the preprocessor will complain. This >> is the pattern that Stephen suggested. > > Also, it would be nice to unravel the "0" vs. "-1" default > inconsistency.
Indeed. I looked at it briefly, but it wasn't immediately clear what the impact would be to switch powerpc over to -1, and it looked to me like sparc depends on -1 to signify no node association.
g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |