lkml.org 
[lkml]   [2010]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] KVM: fix compile warning

    Stephen Rothwell wrote:
    > Hi all,
    >
    > After merging the kvm tree, today's linux-next build (x86_64
    > allmodconfig) produced this warning:
    >
    > arch/x86/kvm/mmu.c: In function 'kvm_mmu_pte_write':
    > arch/x86/kvm/mmu.c:2908: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~'
    >
    > Introduced by commit af8720393c71a8f81ade71c404798d80c68c5d73 ("KVM: MMU:
    > add missing reserved bits check in speculative path").

    Hi Stephen,

    Thanks for your report, this patch can fix it.

    Subject: [PATCH] KVM: fix compile warning

    Fix:
    arch/x86/kvm/mmu.c: In function 'kvm_mmu_pte_write':
    arch/x86/kvm/mmu.c:2908: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~'

    Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
    Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
    ---
    arch/x86/kvm/mmu.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
    index 1a8f43f..0dcc95e 100644
    --- a/arch/x86/kvm/mmu.c
    +++ b/arch/x86/kvm/mmu.c
    @@ -2904,8 +2904,8 @@ void kvm_mmu_pte_write(struct kvm_vcpu *vcpu, gpa_t gpa,
    entry = *spte;
    mmu_pte_write_zap_pte(vcpu, sp, spte);
    if (gentry &&
    - !(sp->role.word ^ vcpu->arch.mmu.base_role.word)
    - & mask.word)
    + !((sp->role.word ^ vcpu->arch.mmu.base_role.word)
    + & mask.word))
    mmu_pte_write_new_pte(vcpu, sp, spte, &gentry);
    if (!remote_flush && need_remote_flush(entry, *spte))
    remote_flush = true;
    --
    1.6.5.2



    \
     
     \ /
      Last update: 2010-07-26 07:53    [W:0.021 / U:1.016 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site