lkml.org 
[lkml]   [2010]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCHv5 12/15] writeback: optimize periodic bdi thread wakeups
    From
    Date
    On Sun, 2010-07-25 at 11:29 +0300, Artem Bityutskiy wrote:
    > +static void wakeup_timer_fn(unsigned long data)
    > +{
    > + struct backing_dev_info *bdi = (struct backing_dev_info *)data;
    > +
    > + spin_lock(&bdi->wb_lock);
    > + if (bdi->wb.task) {
    > + wake_up_process(bdi->wb.task);
    > + } else {
    > + /*
    > + * When bdi tasks are inactive for long time, they are killed.
    > + * In this case we have to wake-up the forker thread which
    > + * should create and run the bdi thread.
    > + */
    > + wake_up_process(default_backing_dev_info.wb.task);
    > + }
    > + spin_unlock(&bdi->wb_lock);
    > +}

    OK, since now we use this lock in a timer, this should become a
    spin_lock_bh().

    --
    Best Regards,
    Artem Bityutskiy (Артём Битюцкий)

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-07-25 12:51    [W:0.021 / U:2.568 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site