Messages in this thread | | | Date | Fri, 23 Jul 2010 20:35:18 +0530 | From | Nitin Gupta <> | Subject | Re: [PATCH V3 0/8] Cleancache: overview |
| |
On 07/23/2010 08:14 PM, Dan Magenheimer wrote: >> From: Christoph Hellwig [mailto:hch@infradead.org]
>> Also making the ops vector global is just a bad idea. >> There is nothing making this sort of caching inherently global. > > I'm not sure I understand your point, but two very different > users of cleancache have been provided, and more will be > discussed at the MM summit next month. > > Do you have a suggestion on how to avoid a global ops > vector while still serving the needs of both existing > users?
Maybe introduce cleancache_register(struct cleancache_ops *ops)? This will allow making cleancache_ops non-global. No value add but maybe that's cleaner?
Thanks, Nitin
| |