Messages in this thread | | | Date | Thu, 22 Jul 2010 10:14:32 -0400 (EDT) | From | Alan Stern <> | Subject | Re: [PATCHv4 5/5] USB: gadget: file_storage: serial parameter even if not test mode |
| |
On Thu, 22 Jul 2010, Michal Nazarewicz wrote:
> Moved the serial parameter handling code out of "#ifdef > CONFIG_USB_FILE_STORAGE_TEST". > > This modifies Yann Cantin's commit "USB: Add a serial number > parameter to g_file_storage" module as per Alan Stern's request. > > Signed-off-by: Michal Nazarewicz <m.nazarewicz@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > Cc: Alan Stern <stern@rowland.harvard.edu> > Cc: Yann Cantin <yann.cantin@laposte.net> > --- > Alan Stern wrote: > > I have only one objection to this [Yann Cantin's] patch: The new > > parameter's name should be "serial", not "serial_parm". > > Alan Stern wrote: > > The serial number parameter is important enough that it should be > > available even on builds without CONFIG_USB_FILE_STORAGE_TEST. > > drivers/usb/gadget/file_storage.c | 20 +++++++++++--------- > 1 files changed, 11 insertions(+), 9 deletions(-)
Acked-by: Alan Stern <stern@rowland.harvard.edu>
| |