Messages in this thread | | | Date | Wed, 21 Jul 2010 20:59:48 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] BISECTED x86: avoid qword access in memcpy_*io |
| |
On 07/21/2010 06:23 PM, Hidetoshi Seto wrote: > > It seems that lpfc already implemented lpfc_memcpy_{to,from}_slim() > as such memcpy_*io32, but limited use of it to on big endian platforms > only. Now lpfc can move to use it always, right? >
What it probably should do is instead of open-coding this stuff use __iowrite32_copy and we probably should have a version without double underscores which byteswaps on bigendian.
Personally I would not object to seeing a patch renaming __iowrite32_copy() to memcpy_toio32()... especially since it doesn't have the "memory or I/O space" property of iowrite and friends.
-hpa
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
| |