Messages in this thread | | | Date | Wed, 21 Jul 2010 22:56:08 +0200 | From | Michał Nazarewicz <> | Subject | Re: [PATCH 2/4] mm: cma: Contiguous Memory Allocator added |
| |
On Wed, 21 Jul 2010 22:45:43 +0200, Daniel Walker <dwalker@codeaurora.org> wrote: > Your not hearing the issues.. IT'S TOO COMPLEX! Please remove it.
Remove what exactly?
The command line parameter? It's like 50 lines of code, so I don't see any benefits.
The possibility to specify the configuration? It would defy the whole purpose of CMA, so I won't do that.
The complexity has to be there one way or the other and even though I am aware that less complex code is the better and am trying to remove unnecessary complexity but saying “remove it” won't make any good unless you provide me with a better alternative. At this point, I am still convinced that the string parameters are the best option.
-- Best regards, _ _ | Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o | Computer Science, Michał "mina86" Nazarewicz (o o) +----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |