Messages in this thread Patch in this message | | | From | Kulikov Vasiliy <> | Subject | [PATCH 2/2] edac: i5400: carefull error handling | Date | Wed, 21 Jul 2010 23:07:25 +0400 |
| |
-EIO is not the only error code that pci_enable_device() may return, also the set of errors can be enhanced in future. We should compare return code with zero, not with concrete error value.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> --- drivers/edac/i5400_edac.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/edac/i5400_edac.c b/drivers/edac/i5400_edac.c index 010c1d6..38a9be9 100644 --- a/drivers/edac/i5400_edac.c +++ b/drivers/edac/i5400_edac.c @@ -1348,7 +1348,7 @@ static int __devinit i5400_init_one(struct pci_dev *pdev, /* wake up device */ rc = pci_enable_device(pdev); - if (rc == -EIO) + if (rc) return rc; /* now probe and enable the device */ -- 1.7.0.4
| |