lkml.org 
[lkml]   [2010]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 4/7] cifs: use workqueue instead of slow-work
From
On Tue, Jul 20, 2010 at 3:34 PM, Tejun Heo <tj@kernel.org> wrote:
> Workqueue can now handle high concurrency.  Use system_nrt_wq
> instead of slow-work.
>
> * Updated is_valid_oplock_break() to not call cifs_oplock_break_put()
>  as advised by Steve French.  It might cause deadlock.  Instead,
>  reference is increased after queueing succeeded and
>  cifs_oplock_break() briefly grabs GlobalSMBSeslock before putting
>  the cfile to make sure it doesn't put before the matching get is
>  finished.
>
> * Anton Blanchard reported that cifs conversion was using now gone
>  system_single_wq.  Use system_nrt_wq which provides non-reentrance
>  guarantee which is enough and much better.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Steve French <sfrench@samba.org>
> Cc: Anton Blanchard <anton@samba.org>
> ---
>  fs/cifs/Kconfig    |    1 -
>  fs/cifs/cifsfs.c   |    5 -----
>  fs/cifs/cifsglob.h |    8 +++++---
>  fs/cifs/dir.c      |    2 +-
>  fs/cifs/file.c     |   30 +++++++++++++-----------------
>  fs/cifs/misc.c     |   20 ++++++++++++--------
>  6 files changed, 31 insertions(+), 35 deletions(-)

Acked-by: Steve French <sfrench@us.ibm.com>



--
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-07-21 17:49    [from the cache]
©2003-2011 Jasper Spaans