lkml.org 
[lkml]   [2010]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/3] sound/isa/gus: Remove dead CONFIG_SND_DEBUG_ROM
    At Wed, 21 Jul 2010 14:36:02 +0200,
    Christian Dietrich wrote:
    >
    > CONFIG_SND_DEBUG_ROM doesn't exist in Kconfig, therefore it is never
    > defined and we can remove all references to it. If it should stay as a
    > debug flag, perhaps it shouldn't be named CONFIG_
    >
    > Signed-off-by: Christian Dietrich <qy03fugy@stud.informatik.uni-erlangen.de>

    This is rather a debug code, so it's often useful to keep as is.
    At bets, we can rename the ifdef without CONFIG_ prefix.


    thanks,

    Takashi

    > ---
    > sound/isa/gus/interwave.c | 8 --------
    > 1 files changed, 0 insertions(+), 8 deletions(-)
    >
    > diff --git a/sound/isa/gus/interwave.c b/sound/isa/gus/interwave.c
    > index c7b80e4..ac60c7d 100644
    > --- a/sound/isa/gus/interwave.c
    > +++ b/sound/isa/gus/interwave.c
    > @@ -442,19 +442,11 @@ static void __devinit snd_interwave_detect_memory(struct snd_gus_card * gus)
    > for (bank_pos = 0; bank_pos < 16L * 1024L * 1024L; bank_pos += 4L * 1024L * 1024L) {
    > for (i = 0; i < 8; ++i)
    > iwave[i] = snd_gf1_peek(gus, bank_pos + i);
    > -#ifdef CONFIG_SND_DEBUG_ROM
    > - printk(KERN_DEBUG "ROM at 0x%06x = %02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x\n", bank_pos,
    > - iwave[0], iwave[1], iwave[2], iwave[3],
    > - iwave[4], iwave[5], iwave[6], iwave[7]);
    > -#endif
    > if (strncmp(iwave, "INTRWAVE", 8))
    > continue; /* first check */
    > csum = 0;
    > for (i = 0; i < sizeof(struct rom_hdr); i++)
    > csum += snd_gf1_peek(gus, bank_pos + i);
    > -#ifdef CONFIG_SND_DEBUG_ROM
    > - printk(KERN_DEBUG "ROM checksum = 0x%x (computed)\n", csum);
    > -#endif
    > if (csum != 0)
    > continue; /* not valid rom */
    > gus->gf1.rom_banks++;
    > --
    > 1.7.0.4
    >


    \
     
     \ /
      Last update: 2010-07-21 14:59    [W:0.022 / U:30.640 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site