lkml.org 
[lkml]   [2010]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] mfd: MAX8998: Add interrupts support
On 7/20/2010 5:55 PM, Mark Brown wrote:
> On Tue, Jul 20, 2010 at 03:57:37PM +0900, Joonyoung Shim wrote:
>> Use genirq and provide seperated file for interrupts support.
>>
>> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> ...
>
>> +
>> + for (i = 0; i < ARRAY_SIZE(max8998->irq_masks_cur); i++) {
>> + /*
>> + * If there's been a change in the mask write it back
>> + * to the hardware.
>> + */
>> + if (max8998->irq_masks_cur[i] != max8998->irq_masks_cache[i]) {
>> + max8998->irq_masks_cache[i] = max8998->irq_masks_cur[i];
>> + max8998_write_reg(max8998->i2c, MAX8998_REG_IRQM1 + i,
>> + max8998->irq_masks_cur[i]);
>> + }
>
> This code all looks oddly familiar :)

Yes, i didn't have any needs to use other way.

>
> Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>


\
 
 \ /
  Last update: 2010-07-20 11:57    [W:0.071 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site