Messages in this thread | | | Date | Tue, 20 Jul 2010 09:55:54 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 2/3] mfd: MAX8998: Add interrupts support |
| |
On Tue, Jul 20, 2010 at 03:57:37PM +0900, Joonyoung Shim wrote: > Use genirq and provide seperated file for interrupts support. > > Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
...
> + > + for (i = 0; i < ARRAY_SIZE(max8998->irq_masks_cur); i++) { > + /* > + * If there's been a change in the mask write it back > + * to the hardware. > + */ > + if (max8998->irq_masks_cur[i] != max8998->irq_masks_cache[i]) { > + max8998->irq_masks_cache[i] = max8998->irq_masks_cur[i]; > + max8998_write_reg(max8998->i2c, MAX8998_REG_IRQM1 + i, > + max8998->irq_masks_cur[i]); > + }
This code all looks oddly familiar :)
Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
| |