Messages in this thread | | | Date | Tue, 20 Jul 2010 15:51:07 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 09/10] x86, xsave: check cpuid level for XSTATE_CPUID (0x0d) |
| |
On 07/20/2010 03:26 PM, Suresh Siddha wrote: > On Tue, 2010-07-20 at 11:50 -0700, Robert Richter wrote: >> The patch adds a check that tests if XSTATE_CPUID exists. >> >> Signed-off-by: Robert Richter <robert.richter@amd.com> > > While we are at this, can you please rename the other hardcoded 0xd's > with XSTATE_CPUID in xsave.c? > >> + struct cpuinfo_x86 *c = &cpu_data(0); > > Can we use boot_cpu_data instead of cpu_data(0). >
I think boot_cpu_data is the right thing for the early stuff like this (early_cpu_init() initializes boot_cpu_data, not cpu_data(0)) so just use boot_cpu_data.cpuid_level instead of forming a pointer.
-hpa
| |