Messages in this thread | | | From | Dmitry Torokhov <> | Subject | Re: [PATCH 5/5] input: i8042 - add runtime check in x86's i8042_platform_init | Date | Fri, 2 Jul 2010 09:59:23 -0700 |
| |
Hi Feng,
On Friday, July 02, 2010 01:35:16 am feng.tang@intel.com wrote: > From: Feng Tang <feng.tang@intel.com> > > Then it will first check x86_platforms's i8042 detection result, > then go on with normal probe. > > Cc: Dmitry Torokhov <dtor@mail.ru> > Signed-off-by: Feng Tang <feng.tang@intel.com> > --- > drivers/input/serio/i8042-x86ia64io.h | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/input/serio/i8042-x86ia64io.h > b/drivers/input/serio/i8042-x86ia64io.h index 6168469..2e14fc5 100644 > --- a/drivers/input/serio/i8042-x86ia64io.h > +++ b/drivers/input/serio/i8042-x86ia64io.h > @@ -840,6 +840,10 @@ static int __init i8042_platform_init(void) > { > int retval; > > + /* Just return if pre-detection shows no i8042 controller exist */ > + if (!x86_platform.i8042_detect()) > + return -ENODEV; > +
I think this needs to be protected with "#ifdef CONFIG_X86" as the file is shared between X86 and IA64.
Thanks,
Dmitry
| |