Messages in this thread Patch in this message | | | From | Venkatesh Pallipadi <> | Subject | Re: [PATCH] sched: Call update_group_power only for local_group | Date | Fri, 2 Jul 2010 09:56:39 -0700 |
| |
My fault. I completely missed that code path, assuming this_cpu in load_balance means this_cpu :(
How about the change below instead?
Signed-off-by: Venkatesh Pallipadi <venki@google.com> --- kernel/sched_fair.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c index a878b53..97f4534 100644 --- a/kernel/sched_fair.c +++ b/kernel/sched_fair.c @@ -2406,8 +2406,6 @@ static inline void update_sg_lb_stats(struct sched_domain *sd, return; } - update_group_power(sd, this_cpu); - /* Adjust by relative CPU power of the group */ sgs->avg_load = (sgs->group_load * SCHED_LOAD_SCALE) / group->cpu_power; @@ -2456,6 +2454,8 @@ static inline void update_sd_lb_stats(struct sched_domain *sd, int this_cpu, init_sd_power_savings_stats(sd, sds, idle); load_idx = get_sd_load_idx(sd, idle); + update_group_power(sd, this_cpu); + do { int local_group; -- 1.7.1
| |