| Date | Sun, 18 Jul 2010 10:53:08 +0300 | From | Pekka Enberg <> | Subject | Re: [PATCH 7/8] Use xvmalloc to store compressed chunks |
| |
Nitin Gupta wrote: > @@ -528,17 +581,32 @@ static int zcache_store_page(struct zcache_inode_rb *znode, > goto out; > } > > - dest_data = kmap_atomic(zpage, KM_USER0); > + local_irq_save(flags);
Does xv_malloc() required interrupts to be disabled? If so, why doesn't the function do it by itself?
> + ret = xv_malloc(zpool->xv_pool, clen + sizeof(*zheader), > + &zpage, &zoffset, GFP_NOWAIT); > + local_irq_restore(flags); > + if (unlikely(ret)) { > + ret = -ENOMEM; > + preempt_enable(); > + goto out; > + }
|