On Sat, 17 Jul 2010 11:21:03 +0200 Krzysztof Halasa wrote:

> Dimitrios Apostolou <jimis@gmx.net> writes:
> 
> > static void update_group_shares_cpu(struct task_group *tg, int cpu,
> >                                     unsigned long sd_shares,
> >                                     unsigned long sd_rq_weight,
> >                                     unsigned long *usd_rq_weight)
> > {
> 
> From a technical POV the above should not have any tabs, the parameters
> should be aligned with spaces only.

fwiw, it seems that you agree with Ted.

> The tabs should be used for (syntactic) indentation only.
> 
> This way we can display the code correctly with any tab length.

but we know what the tab length is.  ;)

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***