lkml.org 
[lkml]   [2010]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [S+Q2 00/19] SLUB with queueing (V2) beats SLAB netperf TCP_RR
On Fri, 16 Jul 2010, Pekka Enberg wrote:

> > I'd also consider patch 7 for 2.6.35-rc6 (and -stable).
>
> It's an obvious bug fix but is it triggered in practice? Is there a bugzilla
> report for that?
>

Let's ask Benjamin who initially reported the problem with arch_initcall
whether or not this is rc (and stable) material.

For reference, we're talking about the sysfs_slab_remove() check on
slab_state to prevent the WARN in the kobject code you hit with its fix
below:


From: Christoph Lameter <cl@linux-foundation.org>

slub: Allow removal of slab caches during boot

If a slab cache is removed before we have setup sysfs then simply skip over
the sysfs handling.

Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Roland Dreier <rdreier@cisco.com>
Signed-off-by: Christoph Lameter <cl@linux-foundation.org>

---
mm/slub.c | 7 +++++++
1 file changed, 7 insertions(+)
Index: linux-2.6/mm/slub.c
===================================================================
--- linux-2.6.orig/mm/slub.c 2010-07-06 15:13:48.000000000 -0500
+++ linux-2.6/mm/slub.c 2010-07-06 15:15:27.000000000 -0500
@@ -4507,6 +4507,13 @@ static int sysfs_slab_add(struct kmem_ca

static void sysfs_slab_remove(struct kmem_cache *s)
{
+ if (slab_state < SYSFS)
+ /*
+ * Sysfs has not been setup yet so no need to remove the
+ * cache from sysfs.
+ */
+ return;
+
kobject_uevent(&s->kobj, KOBJ_REMOVE);
kobject_del(&s->kobj);
kobject_put(&s->kobj);

\
 
 \ /
  Last update: 2010-07-16 11:05    [from the cache]
©2003-2011 Jasper Spaans