Messages in this thread | | | Date | Fri, 16 Jul 2010 09:02:32 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 1/2] x86: fix keeping track of AMD C1E |
| |
On 07/16/2010 12:22 AM, Borislav Petkov wrote: >> >> No, the difference between using a separate variable and the CPU feature >> bit is that CPU feature bit is ANDed across all CPUs, whereas this >> variable is set if it is set on *any* CPU. > > ... and that's ok because the MSR bits get set on all cores after BIOS > turns on C1E. Let me verify this though. >
Is there any reason for the OR behavior? Otherwise, it's just plain wrong...
-hpa
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
| |