lkml.org 
[lkml]   [2010]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] slob_free:free objects to their own list
From
On Wed, Jul 14, 2010 at 5:07 PM, Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> On Wed, Jul 14, 2010 at 12:53 AM, Matt Mackall <mpm@selenic.com> wrote:
>> On Tue, 2010-07-13 at 20:52 +0300, Pekka Enberg wrote:
>>> Hi Bob,
>>>
>>> [ Please CC me on SLOB patches. You can use the 'scripts/get_maintainer.pl'
>>>   script to figure out automatically who to CC on your patches. ]
>>>
>>> On Sat, Jul 10, 2010 at 1:05 PM, Bob Liu <lliubbo@gmail.com> wrote:
>>> > slob has alloced smaller objects from their own list in reduce
>>> > overall external fragmentation and increase repeatability,
>>> > free to their own list also.
>>> >
>>> > Signed-off-by: Bob Liu <lliubbo@gmail.com>
>>>
>>> The patch looks sane to me. Matt, does it look OK to you as well?
>>
>> Yep, this should be a marginal improvement.
>>
>> Acked-by: Matt Mackall <mpm@selenic.com>
>
> Great! Bob, if you could provide the /proc/meminfo numbers for the
> patch description, I'd be more than happy to merge this.
>
Hi, Pekka

Sorry for the wrong cc and later reply.
This is /proc/meminfo result in my test machine:
without this patch:
===
MemTotal: 1030720 kB
MemFree: 750012 kB
Buffers: 15496 kB
Cached: 160396 kB
SwapCached: 0 kB
Active: 105024 kB
Inactive: 145604 kB
Active(anon): 74816 kB
Inactive(anon): 2180 kB
Active(file): 30208 kB
Inactive(file): 143424 kB
Unevictable: 16 kB
....

with this patch:
===
MemTotal: 1030720 kB
MemFree: 751908 kB
Buffers: 15492 kB
Cached: 160280 kB
SwapCached: 0 kB
Active: 102720 kB
Inactive: 146140 kB
Active(anon): 73168 kB
Inactive(anon): 2180 kB
Active(file): 29552 kB
Inactive(file): 143960 kB
Unevictable: 16 kB
...

The result show only very small improverment!
And when i tested it on a embeded system with 64MB, I found this path
is never called while kernel booting.

Thanks for the kindly review.

--
Regards,
--Bob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-07-16 07:49    [W:0.048 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site