Messages in this thread | | | Date | Thu, 15 Jul 2010 12:17:46 +0200 (CEST) | From | Jan Engelhardt <> | Subject | Re: several messages |
| |
On Thursday 2010-07-15 11:36, Patrick McHardy wrote: >> +struct xt_CHECKSUM_info { >> + u_int8_t operation; /* bitset of operations */ > >Please use __u8 in public header files. > >> +#include <linux/in.h> > >Do you really need in.h? > >> + * $Id$ > >Please no CVS IDs. > >> + switch (c) { >> + case 'F': >> + if (*flags) >> + xtables_error(PARAMETER_PROBLEM, >> + "CHECKSUM target: Only use --checksum-fill ONCE!"); > >There is a helper function called xtables_param_act for checking double >arguments and printing a standarized error message.
I took care of these for Xt-a.
| |