lkml.org 
[lkml]   [2010]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Drivers: net: 8139cp: Fixed 28 style errors, and 119 warnings.

> -/* The following settings are log_2(bytes)-4: 0 == 16 bytes .. 6==1024, 7==end of packet. */
> -#define RX_FIFO_THRESH 5 /* Rx buffer level before first PCI xfer. */
> +/* The following settings are log_2(bytes)-4: 0 == 16 bytes .. 6 == 1024, 7 == end of packet. */
> +#define RX_FIFO_THRESH 5 /* Rx buffer level before first PCI xfer. */

useless noise

> - unsigned wol_enabled : 1; /* Is Wake-on-LAN enabled? */
> + unsigned wol_enabled:1; /* Is Wake-on-LAN enabled? */

not an improvement

> - if (wol->wolopts & WAKE_PHY) options |= LinkUp;
> - if (wol->wolopts & WAKE_MAGIC) options |= MagicPacket;
> + if (wol->wolopts & WAKE_PHY)
> + options |= LinkUp;
> + if (wol->wolopts & WAKE_MAGIC)
> + options |= MagicPacket;

ditto

> - if (wol->wolopts & WAKE_UCAST) options |= UWF;
> - if (wol->wolopts & WAKE_BCAST) options |= BWF;
> - if (wol->wolopts & WAKE_MCAST) options |= MWF;
> + if (wol->wolopts & WAKE_UCAST)
> + options |= UWF;
> + if (wol->wolopts & WAKE_BCAST)
> + options |= BWF;
> + if (wol->wolopts & WAKE_MCAST)
> + options |= MWF;

ditto
>
> - if (options & UWF) wol->wolopts |= WAKE_UCAST;
> - if (options & BWF) wol->wolopts |= WAKE_BCAST;
> - if (options & MWF) wol->wolopts |= WAKE_MCAST;
> + options = cpr8(Config5);
> + if (options & UWF)
> + wol->wolopts |= WAKE_UCAST;
> + if (options & BWF)
> + wol->wolopts |= WAKE_BCAST;
> + if (options & MWF)
> + wol->wolopts |= WAKE_MCAST;

ditto



\
 
 \ /
  Last update: 2010-07-16 02:59    [W:0.054 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site