Messages in this thread | | | Date | Thu, 15 Jul 2010 20:57:19 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH] Drivers: net: 8139cp: Fixed 28 style errors, and 119 warnings. |
| |
> -/* The following settings are log_2(bytes)-4: 0 == 16 bytes .. 6==1024, 7==end of packet. */ > -#define RX_FIFO_THRESH 5 /* Rx buffer level before first PCI xfer. */ > +/* The following settings are log_2(bytes)-4: 0 == 16 bytes .. 6 == 1024, 7 == end of packet. */ > +#define RX_FIFO_THRESH 5 /* Rx buffer level before first PCI xfer. */
useless noise
> - unsigned wol_enabled : 1; /* Is Wake-on-LAN enabled? */ > + unsigned wol_enabled:1; /* Is Wake-on-LAN enabled? */
not an improvement
> - if (wol->wolopts & WAKE_PHY) options |= LinkUp; > - if (wol->wolopts & WAKE_MAGIC) options |= MagicPacket; > + if (wol->wolopts & WAKE_PHY) > + options |= LinkUp; > + if (wol->wolopts & WAKE_MAGIC) > + options |= MagicPacket;
ditto
> - if (wol->wolopts & WAKE_UCAST) options |= UWF; > - if (wol->wolopts & WAKE_BCAST) options |= BWF; > - if (wol->wolopts & WAKE_MCAST) options |= MWF; > + if (wol->wolopts & WAKE_UCAST) > + options |= UWF; > + if (wol->wolopts & WAKE_BCAST) > + options |= BWF; > + if (wol->wolopts & WAKE_MCAST) > + options |= MWF;
ditto > > - if (options & UWF) wol->wolopts |= WAKE_UCAST; > - if (options & BWF) wol->wolopts |= WAKE_BCAST; > - if (options & MWF) wol->wolopts |= WAKE_MCAST; > + options = cpr8(Config5); > + if (options & UWF) > + wol->wolopts |= WAKE_UCAST; > + if (options & BWF) > + wol->wolopts |= WAKE_BCAST; > + if (options & MWF) > + wol->wolopts |= WAKE_MCAST;
ditto
| |