[lkml]   [2010]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2.6.35-rc1] net-next: vmxnet3 fixes [3/5] Initialize link state at probe time
From: Shreyas Bhatewara <>
Date: Tue, 13 Jul 2010 17:48:55 -0700 (PDT)

> Initialize vmxnet3 link state at probe time
> This change initializes the state of link at the time when driver is
> loaded. The ethtool output for 'link detected' and 'link speed'
> is thus valid even before the interface is brought up.
> Signed-off-by: Shreyas Bhatewara <>

You should never, ever, call netif_start_queue() on a device which has
not been brought up.

But that is what this patch is doing.

 \ /
  Last update: 2010-07-14 23:13    [W:0.353 / U:2.168 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site