Messages in this thread | | | Date | Wed, 14 Jul 2010 08:40:02 +0800 | From | Gui Jianfeng <> | Subject | Re: [PATCH] CFQ: Don't store left slice when slice used up or for a idle workload |
| |
Jeff Moyer wrote: > Gui Jianfeng <guijianfeng@cn.fujitsu.com> writes: > >> It doesn't make sence to store left time slice for an idle workload >> or for the cfqq that uses up its slice. > > Did you actually observe any problems? As I understand it, if you > overrun your slice you get a negative offset, so I think we want to keep > that.
Hi Jeff
If that's the case, do we also need to store the negative offset when slice used up in cfq_select_queue() and cfq_idle_slice_timer()?
Thanks Gui
> > Cheers, > Jeff > >
| |