lkml.org 
[lkml]   [2010]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 6/9] KVM: MMU: introduce pte_prefetch_topup_memory_cache()


Avi Kivity wrote:
> On 07/13/2010 07:25 AM, Xiao Guangrong wrote:
>>
>>> Regressions? no. Or do you mean the problem already exists? Where?
>>>
>> I mean this is a exist problem, likes invlpg, pte-write and sync-page,
>> there are
>> speculative path that it's not real access, but marked dirty if pte is
>> writable.
>>
>
> Right. We should fix those too.
>
> Prefetch is much more worrying though, especially with ept. If a guest
> is using just 1/8 of the pages, it can look to migration as if it's
> using 100% of the pages. The impact can be pretty large.

We disabled prefetch if ept is enabled since it can break access bit tracking.

I'll fix the dirty bit tracking before post the new version of this patchset.


\
 
 \ /
  Last update: 2010-07-13 07:55    [from the cache]
©2003-2011 Jasper Spaans