Messages in this thread | | | Date | Tue, 13 Jul 2010 20:43:05 +0300 | From | Pekka Enberg <> | Subject | Re: [PATCH] x86: Setup early console as early as possible |
| |
Hi Yingahai,
Yinghai Lu wrote: > On 07/12/2010 08:47 AM, H. Peter Anvin wrote: >> On 07/12/2010 01:58 AM, Pekka Enberg wrote: >>> Hi Yinghai, >>> >>> Yinghai Lu wrote: >>>> Analyze "console=uart8250,io,0x3f8,115200n8" in >>>> i386_start_kernel/x86_64_start_kernel, >>>> and call setup_early_serial8250_console() to init early serial console. >>>> >>>> only can handle io port kind of 8250. because mmio need ioremap. >>>> >>>> Signed-off-by: Yinghai Lu <yinghai@kernel.org> >>> What's the purpose of this patch? Does it make my early boot I/O patch >>> obsolete? >>> >>> Pekka >> No, they're complementary. Your patch serial-port enables the RM >> kernel, whereas Yinghai pushes the initialization earlier in the PM kernel. > > yes. cover more range. > > Can you consider to ask Pekka to anaylze "console=uart8250,io, 0x3f8,115200n8" instead? > > it looks like we can remove "earlyprintk=ttyS0,115200", or "earlyprintk=serial" etc. > > earlycon=uart8250 or console=uart8250 should be better than earlyprintk. > because it is shared between different archs already.
So just to clarify: I wasn't ignoring your comment here. I simply followed hpa's recommendation on which I also happen to agree with completely. ;-)
Pekka
| |