Messages in this thread | | | Date | Tue, 13 Jul 2010 15:17:10 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v2 1/2] regulator: add support for regulators on the ab8500 MFD |
| |
On Tue, Jul 13, 2010 at 07:39:32PM +0530, Sundar Iyer wrote:
> + * @mask: mask to enable/disable regulator > + * @enable: bits to enable the regulator in normal(high power) mode
Have you addressed my comments here?
> + ret = ab8500_get_best_voltage_index(rdev, min_uV, max_uV); > + if (ret < 0) { > + dev_dbg(rdev_get_dev(rdev), > + "coudlnt get best voltage for regulator\n");
Typo here. Also, shouldn't your error messages be errors rather than debug output?
| |